Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The documentation mentions support for multi-route/multi-layout modes being planned in the future.
Given that we'd like to start using this functionality, we'd be happy to contribute it.
Changes & Results
Updated ModeRoute (
platform/app/src/routes/Mode/Mode.tsx
) to accept an optionalmodeRoutePath
proproute
of a given mode)route
object with the matchingpath
parameter frommode.routes
Updated buildModeRoutes logic (
platform/app/src/routes/buildModeRoutes.tsx
)In addition to generating & registering
/{mode.routeName}
and/{mode.routeName}/{dataSourceID}
paths, we generate & register for each route in a mode/{mode.routeName}/{mode.route[n].path}
route/{mode.routeName}/{mode.route[n].path}/{dataSourceID}
pathGiven that we still register the
/{mode.routeName}
and/{mode.routeName}/{dataSourceID}
paths, the router retains previous functionality.Testing
basic-dev-mode
or temporarily add the following to the longitudinal mode's (modes/longitudinal/src/index.ts
) routes:yarn dev
/viewer?...
URL/viewer/dicomweb?....
) still works/viewer/longitudinal?....
) worksviewer/panelless?...
) works and renders without any side panelsviewer/panelless/dicomweb?...
)Checklist
PR
feat(ModeRoute): add support for rendering an explicit route
feat(buildModeRoutes): generate an explicit route mapping for each route in a mode
My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment